emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: rfn-eshadow


From: Stefan Monnier
Subject: Re: rfn-eshadow
Date: Sat, 05 Jan 2008 17:34:29 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.50 (gnu/linux)

>>> Doesn't look like a right solution to me since url-handlers.el causes
>>> loading two additional files from the url package and two files from gnus.
>> 
>> But most of the url* files are already loaded when applying
>> `ffap'. Start "emacs -Q", and compare `load-history' before and after
>> calling `ffap' on a URL-like string.

> Ah, I didn't notice that ffap already loads url* files via url-normalize-url.
> In this case there is no problem with that.  The only problem I see is that
> after reading an URL by ffap, the value of the variable `url-handler-mode'
> is t, but really this mode is not active since file-name-handler-alist
> doesn't keep the corresponding entry.  You can fix this by adding an empty
> let-binding in `ffap-read-file-or-url' for the variable `url-handler-mode'
> exactly as you did for `file-name-handler-alist' to not keep its new value.
> If nobody objects, could you also fix this in the Emacs 22 branch?

Of course additional let bindings are needed for every variable modified
by the call to url-handle-mode.  So you end up writing code that makes
assumptions about the inner working of url-handler-mode.
Maybe we may as well just add (cons url-handler-regexp
'url-file-handler) to file-name-handler-mode rather than call
url-handler-mode.


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]