Re: functionp bug

[Reiner Steib]

On Thu, Apr 10 2008, Katsumi Yamaoka wrote:

>>>>>> Stefan Monnier wrote:
>>>>> 1. Merge Stefan's changes:
>
>>>> Miles's sync between Gnus's CVS and Emacs's CVS will do that anyway.
>>>> Maybe you want to ask Miles to do a round of sync'ing (he seems to have
>>>> been a bit busy with other things recently).
>
>>> The release of No Gnus v0.8 and Gnus v5.10.10 is just around the
>>> corner so merging is stopped.  

It's more coincidence the Miles it too busy to sync.

>>> It's why the problems concerning the functionp change happen here
>>> and there.
>
>> Sorry, I missed this part.  Yes, this change should clearly be merged.
>
> I left it to the release maintainer.  
[ Quoting re-ordered ]
> Please note that all the changes have to be verified also with
> Emacs 21 and 22 and XEmacs 21.4 and 21.5.  That's my routine.

Did anyone verify that Stefan's changes are safe also for Emacs 21/22
and XEmacs 21.4/21.5?

>> Actually, sync'ing shouldn't be stopped, really.  Emacs's version of
>> Gnus should simply follow the same "bug fix only" policy.

As No Gnus 0.8 is just a development snapshot, I don't want to invest
too much time to enforce such a policy.  (And I didn't know when the
release will be done, because I didn't hear from Lars for some weeks.
Maybe he was on holidays.)

As pointed out in <news:address@hidden> /
<http://thread.gmane.org/gmane.emacs.gnus.general/66553/focus=66746>,
it's not very important to have the Gnus 5.10.10/No Gnus 0.8 work with
Emacs trunk:

- It's important that Gnus 5.10.10 works well with Emacs 21 and XEmacs
  21.4/21.5.  Users of Emacs 22 should use Gnus 5.11 bundled with
  Emacs 22.2.  Users of Emacs 23 (trunk), shouldn't use Gnus 5.10 at
  all.

- It's important that No Gnus 0.8 works well with Emacs 21/22 and
  XEmacs 21.4/21.5.  Users of Emacs 23 (trunk), should use either the
  bundled Gnus 5.13 or Gnus trunk (when Gnus trunk is newer).

> In relation to this, I hope anyone who changes Gnus in the Emacs
> trunk subscribe to the ding list or the gmane.emacs.gnus.general
> newsgroup.

Or at least cc address@hidden when doing non-trivial changes in
lisp/gnus/*.el or changes that are likely to be relevant for Gnus.

Maybe it would have been better to send
<http://thread.gmane.org/address@hidden> to
emacs-devel as well.

Bye, Reiner.

[1] Here's the relevant diff between Emacs trunk Gnus trunk:

--8<---------------cut here---------------start------------->8---
--- emacs/cvs-HEAD/emacs/lisp/gnus/gnus-win.el  2008-04-06 20:15:08.000000000 
+0200
+++ plain_No/lisp/gnus-win.el   2008-01-20 06:23:57.000000000 +0100
@@ -317,7 +317,7 @@
     ;; The SPLIT might be something that is to be evaled to
     ;; return a new SPLIT.
     (while (and (not (assq (car split) gnus-window-to-buffer))
-               (symbolp (car split)) (fboundp (car split)))
+               (functionp (car split)))
       (setq split (eval split)))
     (let* ((type (car split))
           (subs (cddr split))
@@ -380,7 +380,7 @@
          (while subs
            (setq sub (append (pop subs) nil))
            (while (and (not (assq (car sub) gnus-window-to-buffer))
-                       (symbolp (car sub)) (fboundp (car sub)))
+                       (functionp (car sub)))
              (setq sub (eval sub)))
            (when sub
              (push sub comp-subs)
@@ -520,7 +520,7 @@
       ;; The SPLIT might be something that is to be evaled to
       ;; return a new SPLIT.
       (while (and (not (assq (car split) gnus-window-to-buffer))
-                 (symbolp (car split)) (fboundp (car split)))
+                 (functionp (car split)))
        (setq split (eval split)))
 
       (setq type (elt split 0))

-++ emacs/cvs-HEAD/emacs/lisp/gnus/mail-source.el       2008-04-10 
12:10:43.000000000 +0200
+-- plain_No/lisp/mail-source.el        2008-03-14 14:43:32.000000000 +0100
@@ -500,7 +500,8 @@
    ((stringp value)
     value)
    ;; Function
-   ((and (listp value) (symbolp (car value)) (fboundp (car value)))
+   ((and (listp value)
+        (functionp (car value)))
     (eval value))
    ;; Just return the value.
    (t
--8<---------------cut here---------------end--------------->8---
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/