Re: Tool-bar changes

[Stefan Monnier]

>> There seems to be a further problem with your patch, somewhere in the
>> image caching code.  Here is how I am reproducing it:
>> 
>> 1. M-x gnus
>> 2. Open a group
>> 3. q q [exit gnus]
>> 4. M-x gnus
>> 5. Open a group
>> 
>> I get an error.  What seems to be happening is that the contents of
>> tool-bar-find-image-cache are getting corrupted.

> Here is a list of the value entries in tool-bar-find-image-cache:

> ((image :type xpm :file 
> "/home/cyd/trunk/etc/images/gnus/toggle-subscription.xpm")
>  (image :type xpm :file "/home/cyd/trunk/etc/images/describe.xpm")
>  ("DEAD" . 19103923)
>  ("DEAD" . 19103899)
>  ("DEAD" . 19103875)
>  ....

> Looks like some of the lists in there have been garbage-collected.  This
> is probably a GC bug.  Does the GC code know not to reap lists that are
> stored in hash tables?

Hmm... I'll take a look at it.  The hash-table is marked as weak
specifically so that those can be GC'd (whether it's a good idea or
not, I don't know), but if they're GC'd then they should be removed from
the hash-table as well.


        Stefan