Re: Yanking isearch to highlight-regexp

[Stefan Monnier]

> Now here is a patch for hi-lock.el that uses `read-regexp'.
> It also marks `hi-lock-regexp-history' as an obsolete variable
> that is replaced with `regexp-history'.

Sounds good.

> Another change is renaming `hi-lock-face-history' to
> `hi-lock-face-defaults' and putting the face list to the
> minibuffer's default list instead of the history list:

Why is that good?

>                           (try-completion
> !                          (substring (car hi-lock-face-history) 0 1)
>                            (mapcar (lambda (f) (cons f f))
> !                                  hi-lock-face-history))))

I believe the "(mapcar (lambda (f) (cons f f))" can be removed, since
try-completion accepts lists of strings since Emacs-21 IIRC.


        Stefan