[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Commit netiquette.

From: Stefan Monnier
Subject: Re: Commit netiquette.
Date: Thu, 18 Feb 2010 11:14:43 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.91 (gnu/linux)

>> This seems more of a short comming in `bzr log --short' than in the
>> way one writes commit messages.

Not really: it's the whole idea behing "bzr log --short".

> We currently *have* policies about ChangeLog entries and commit logs,
> so I agree with Óscar: it is a good practice and we should require
> people to follow it; and treat people who doesn't the same way we
> treat people who mangles ChangeLog entries (that is, a gentle but firm
> reminder that we have guideliness and we're all expected to follow
> them).

Yes, please, we should require the first line of commit messages to be
an acceptable summary of the whole changeset.

Could someone update log-edit-mode's font-lock patterns so that the
first line is highlighted specially (at least in the Bzr and Arch

I think log-edit-mode should even go further in this direction.
The buffer should be created as



where <blablabla> is the text taken from the ChangeLog.  Then for
backends which support the notion of summary-line, C-c C-c could just
signal an error if the Summary line is still blank.
After that, empty header entries will get removed and the text is passed
as-is to the backend who is then free to pass it as-is to the underlying
VCS or to extract the various fields and do whatever it feels like
with them.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]