emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: EMACS_INT cleanup


From: Andreas Schwab
Subject: Re: EMACS_INT cleanup
Date: Fri, 24 Sep 2010 11:04:28 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)

Lars Magne Ingebrigtsen <address@hidden> writes:

> Stefan Monnier <address@hidden> writes:
>
>> Yes, but using ptrdiff_t will have the advantage that it's just right.
>> Using int requires a cast and an argument for why int is sufficiently
>> large in practice.  Casts are bad, and human-arguments are only OK when
>> we can't argue directly with the compiler.
>
> Yes, I agree.  It would be cleaner to fix the users to all be
> ptrdiff_t.

Or a dedicated typedef.  The ptrdiff_t is an implementation detail of
the SPECPDL_SIZE macro.  Also, specpdl_size should be adjusted.

Andreas.

-- 
Andreas Schwab, address@hidden
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."



reply via email to

[Prev in Thread] Current Thread [Next in Thread]