|
From: | Daniel Colascione |
Subject: | Re: [PATCH] Unconditional quit on SIGUSR2 |
Date: | Mon, 28 Mar 2011 13:12:39 -0700 |
User-agent: | Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.15) Gecko/20110303 Thunderbird/3.1.9 |
On 3/28/2011 1:06 PM, Lennart Borgman wrote:
On Mon, Mar 28, 2011 at 9:56 PM, Daniel Colascione <address@hidden> wrote:On 3/28/2011 12:52 PM, Lennart Borgman wrote:But can't that be taken care of by letting font lock run again?It depends on how fontification is being run. If we're using jit-lock, then I believe we'll try again automatically. If we're using some other approach, then fontification will likely just be canceled until the next time that portion of the buffer is modified. There's also the issue of runaway process filters which I believe also run with quit disabled.Should not all new code use jit-lock for fontification (or the a bit misname fontification-functions)? Is there a lot of old code in Emacs not using jit-lock?
Until we remove everything besides jit-lock, we have to account for its absence. And it still doesn't address the issue of other background work that runs with quit inhibited.
Also, I strongly discourage anyone using fontification-functions directly. Using this function bypass font-lock entirely, breaking font-lock-mode, add-font-lock-keywords, highlight-phrase, and other Emacs features. It also adds no expressive power over font-lock-keywords, and IMHO, fontification-functions should be documented as being for internal use only.
[Prev in Thread] | Current Thread | [Next in Thread] |