[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Unconditional quit on SIGUSR2
From: |
Lennart Borgman |
Subject: |
Re: [PATCH] Unconditional quit on SIGUSR2 |
Date: |
Mon, 28 Mar 2011 22:45:19 +0200 |
On Mon, Mar 28, 2011 at 10:12 PM, Daniel Colascione
<address@hidden> wrote:
>>>>
>>>> But can't that be taken care of by letting font lock run again?
>>>
>>> It depends on how fontification is being run. If we're using jit-lock,
>>> then
>>> I believe we'll try again automatically. If we're using some other
>>> approach, then fontification will likely just be canceled until the next
>>> time that portion of the buffer is modified. There's also the issue of
>>> runaway process filters which I believe also run with quit disabled.
>>
>> Should not all new code use jit-lock for fontification (or the a bit
>> misname fontification-functions)? Is there a lot of old code in Emacs
>> not using jit-lock?
>
> Until we remove everything besides jit-lock, we have to account for its
> absence.
I really would not worry about fontification code that does not yet
use jit-lock. Such code has caused me a lot of trouble and moving it
to jit-lock would be very good. (Maybe jit-lock need some enhancement
for some cases, but let us worry about that instead then.)
> And it still doesn't address the issue of other background work
> that runs with quit inhibited.
True of course.
> Also, I strongly discourage anyone using fontification-functions directly.
> Using this function bypass font-lock entirely, breaking font-lock-mode,
> add-font-lock-keywords, highlight-phrase, and other Emacs features. It also
> adds no expressive power over font-lock-keywords, and IMHO,
> fontification-functions should be documented as being for internal use only.
Thanks, I misremembered. I am using jit-lock-register.
- Re: [PATCH] Unconditional quit on SIGUSR2, (continued)
- Re: [PATCH] Unconditional quit on SIGUSR2, Eli Zaretskii, 2011/03/28
- Re: [PATCH] Unconditional quit on SIGUSR2, Daniel Colascione, 2011/03/28
- Re: [PATCH] Unconditional quit on SIGUSR2, Eli Zaretskii, 2011/03/28
- Re: [PATCH] Unconditional quit on SIGUSR2, Daniel Colascione, 2011/03/28
- Re: [PATCH] Unconditional quit on SIGUSR2, Eli Zaretskii, 2011/03/28
- Re: [PATCH] Unconditional quit on SIGUSR2, Daniel Colascione, 2011/03/28
- Re: [PATCH] Unconditional quit on SIGUSR2, Lennart Borgman, 2011/03/28
- Re: [PATCH] Unconditional quit on SIGUSR2, Daniel Colascione, 2011/03/28
- Re: [PATCH] Unconditional quit on SIGUSR2, Lennart Borgman, 2011/03/28
- Re: [PATCH] Unconditional quit on SIGUSR2, Daniel Colascione, 2011/03/28
- Re: [PATCH] Unconditional quit on SIGUSR2,
Lennart Borgman <=
- In praise of font-lock (Was: Re: [PATCH] Unconditional quit on SIGUSR2), Daniel Colascione, 2011/03/28
- Re: In praise of font-lock (Was: Re: [PATCH] Unconditional quit on SIGUSR2), Lennart Borgman, 2011/03/28
- Re: [PATCH] Unconditional quit on SIGUSR2, chad, 2011/03/28
- Re: [PATCH] Unconditional quit on SIGUSR2, Eli Zaretskii, 2011/03/28
- Re: [PATCH] Unconditional quit on SIGUSR2, Daniel Colascione, 2011/03/28
- Re: [PATCH] Unconditional quit on SIGUSR2, chad, 2011/03/28
- Re: [PATCH] Unconditional quit on SIGUSR2, Daniel Colascione, 2011/03/29
- Re: [PATCH] Unconditional quit on SIGUSR2, Daniel Colascione, 2011/03/29
- Re: [PATCH] Unconditional quit on SIGUSR2, Tom Tromey, 2011/03/29
- Re: [PATCH] Unconditional quit on SIGUSR2, Stefan Monnier, 2011/03/29