[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Proposal: 'struct window' cleanup

From: Stefan Monnier
Subject: Re: Proposal: 'struct window' cleanup
Date: Tue, 22 May 2012 08:39:42 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux)

>> I generally like the idea.  But please don't use "_p" suffixes
>> for variables.  The "p" stands for "predicate" and a predicate is a kind
>> of function, so that's not the right way to say that something is
>> a boolean value.
> OK,  but what about other "struct window" bitfield members whose names
> ends with "_p"?

Yes, I know, just like many Elisp packages use vars with names ending in
"-p" for the same mistaken reason.

> Should we also rename it to obey this naming convention?

No, it's not worth the trouble.

> Also this kind of patch proposes a lot of small and simple changes.
> Is there a convenient way to document them in ChangeLog?

I'd do it like

     * foo.h (struct bar): Use bitfields for field1, field2, field3.
     Adjust users accordingly.

-- Stefan

reply via email to

[Prev in Thread] Current Thread [Next in Thread]