[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] progmodes/vhdl-mode.el: Backported changes from 3.33.

From: Stefan Monnier
Subject: Re: [PATCH 1/2] progmodes/vhdl-mode.el: Backported changes from 3.33.
Date: Thu, 24 May 2012 00:33:18 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux)

> http://www.iis.ee.ethz.ch/~zimmi/emacs/vhdl-mode.html#release-notes-3.33

> Among the changes are
> * Support for ghdl (free vhdl compiler). Now default
> * Add/update support for VHDL-AMS packages.
> * Update to VHDL'02 standard
> ...

> I tried to be very careful not to overwrite any non-upstream changes
> that were made to vhdl-mode.

Thanks.  Your patch got corrupted by line-wrapping.  Could you please
resend it, maybe as a mime-attachment?

Also, while I'm here: are you the vhdl-mode maintainer, or are you
simply helping sync the two versions?

Regarding the code I haven't reviewed it, but I noticed that it
advertises C-c C-c for commenting code, whereas it should advertise M-;

Regarding the second patch you sent: I'm more interested in reducing the
difference between the two versions of vhdl-mode than in making our
version compile without warnings, so I think we're better off without
this patch, unless it's accepted in the upstream version of the code.

Also, while I'm here, do you also sync changes from Emacs's repository
back to the upstream version?  E.g. the use of syntax-propertize-function.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]