[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] progmodes/vhdl-mode.el: Backported changes from 3.33.

From: Rüdiger Sonderfeld
Subject: Re: [PATCH 1/2] progmodes/vhdl-mode.el: Backported changes from 3.33.
Date: Thu, 24 May 2012 19:05:22 +0200
User-agent: KMail/4.8.2 (Linux/3.2.0-24-generic; KDE/4.8.2; x86_64; ; )

On Thursday 24 May 2012 00:33:18 you wrote:
> Thanks.  Your patch got corrupted by line-wrapping.  Could you please
> resend it, maybe as a mime-attachment?

Oh sorry, I guess I forgot to deactivate wordwrap in KMail. I attached both 
patches to this email.

> Also, while I'm here: are you the vhdl-mode maintainer, or are you
> simply helping sync the two versions?

I'm simply helping to sync the two versions. The vhdl-mode maintainer is Reto 

> Regarding the code I haven't reviewed it, but I noticed that it
> advertises C-c C-c for commenting code, whereas it should advertise M-;
> instead.

We could change that downstream. The C-c C-c part is from the current vhdl-
mode release.

> Regarding the second patch you sent: I'm more interested in reducing the
> difference between the two versions of vhdl-mode than in making our
> version compile without warnings, so I think we're better off without
> this patch, unless it's accepted in the upstream version of the code.
> Also, while I'm here, do you also sync changes from Emacs's repository
> back to the upstream version?  E.g. the use of syntax-propertize-function.

I tried to send the patch to the vhdl-mode maintainer but he wants to stay 
compatible to all kind of old and forked emacs and that's why the patch is 
probably not acceptable for him.

Maybe we could send at least the documentation fixes upstream. Reducing the 
differences would be useful. It took a lot of time with diff-mode and git-blame 
to figure out what was changed in emacs and what is new in the vhdl-mode 


Attachment: 0001-progmodes-vhdl-mode.el-Backported-changes-from-3.33.patch
Description: Text Data

Attachment: 0002-progmodes-vhdl-mode-Fixed-use-of-obsolete-functions-.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]