[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Your commit 7409a79
From: |
Tom |
Subject: |
Re: Your commit 7409a79 |
Date: |
Sat, 6 Dec 2014 16:14:42 +0000 (UTC) |
User-agent: |
Loom/3.14 (http://gmane.org/) |
Eli Zaretskii <eliz <at> gnu.org> writes:
>
> Please always start the commit log summary line with a capital letter,
> and end the sentence with a period. (Actually, in the above
> particular case the summary line is redundant and could be omitted --
> but this is a stylistic comment, not a requirement.)
>
> Also, renaming a file needs an entry in the target's ChangeLog, like
> this:
>
> * CONTRIBUTE: Renamed from etc/CONTRIBUTE.
>
> and it also should end with a period, not a comma.
>
These are exactly the situations where a server side commit hook
is really useful for the following reasons:
1. It prevent commits with incorrectly formatted commit messages.
2. It prints an error message describing the problem, thereby
teaching the committer how to make a properly formatted commit.
So there is no need for manually replying to incorrect commits
on the list, because the script checks every commit and even
tells the user the problem.
So it would be a good idea to add such a precommit script to the
server.
- Your commit 7409a79, Eli Zaretskii, 2014/12/06
- Re: Your commit 7409a79, Andreas Schwab, 2014/12/06
- Re: Your commit 7409a79,
Tom <=
- Re: Your commit 7409a79, Stephen Leake, 2014/12/06
- Re: Your commit 7409a79, Eli Zaretskii, 2014/12/06
- Re: Your commit 7409a79, Stephen Leake, 2014/12/07
- Re: Your commit 7409a79, Paul Eggert, 2014/12/07
- Re: Your commit 7409a79, Stephen J. Turnbull, 2014/12/07
- Re: Your commit 7409a79, Eli Zaretskii, 2014/12/08
- Re: Your commit 7409a79, Stephen Leake, 2014/12/08
- Re: Your commit 7409a79, Eli Zaretskii, 2014/12/08