emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Generalize start-process with keyword args


From: Daiki Ueno
Subject: Re: [PATCH] Generalize start-process with keyword args
Date: Tue, 17 Mar 2015 12:39:51 +0900
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux)

Stefan Monnier <address@hidden> writes:

>> I think `:coding' at least needs to be treated specially, because if it
>> is omitted, other methods to determine the coding system take place
>> (`coding-system-for-{read,write}' and `find-operation-coding-system').
>
> Why can't we make it use the same methods when ":coding nil" is specified?

That would mean that the user explicitly specified no-conversion here.

>From the comment in setup_coding_system, which is used by
setup_process_coding_systems:

  /* Setup coding context CODING from information about CODING_SYSTEM.
     If CODING_SYSTEM is nil, `no-conversion' is assumed.  If
     CODING_SYSTEM is invalid, signal an error.  */

> I always found process-connection-type hard to remember.  I think it
> should either have been named process-connection-use-pty, or its values
> should have been pty/pipe.  So I think for :connection-type, it would
> make sense to require the use of either `pipe' or `pty' (or nil to use
> the default rules).

Ah, yes, that's a good idea.

Regards,
-- 
Daiki Ueno



reply via email to

[Prev in Thread] Current Thread [Next in Thread]