[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: unsolicited patch to image-mode.el -- "fit to window"

From: martin rudalics
Subject: Re: unsolicited patch to image-mode.el -- "fit to window"
Date: Fri, 24 Jul 2015 07:30:52 +0200

> a "coding philosophy" question, though. there are a dozen or so other
> references to (window-size-pixel-edges) (and its associated (nth)'s) in
> the code.  my tendency would be to change none (in a patch) or all (in a
> more substantive re-write).  changing all -- while "trivial" -- is, of
> course, more likely to introduce bug, and i don't know of any test suite
> for image mode?

If such code is not buggy, it should be changed only when and only by
the person(s) working on it.  Otherwise, as you say, it's too easy to
introduce a bug in code that was correct before.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]