[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] master 90e9cf8: * lisp/gnus/mailcap.el (mailcap-mime-d
From: |
Katsumi Yamaoka |
Subject: |
Re: [Emacs-diffs] master 90e9cf8: * lisp/gnus/mailcap.el (mailcap-mime-data): |
Date: |
Wed, 21 Oct 2015 09:32:11 +0900 |
User-agent: |
Gnus/5.130014 (真 Gnus v0.14) Emacs/25.0.50 (i686-pc-cygwin) |
On Tue, 20 Oct 2015 10:15:09 -0400, Stefan Monnier wrote:
>> ("pdf"
>> (viewer . doc-view-mode)
>> (type . "application/pdf")
>> - (test . (eq window-system 'x)))
>> + (test . (and (fboundp 'doc-view-mode)
>> + (eq window-system 'x))))
> Should this be redundant? I mean shouldn't the generic code check
> fboundp of the `viewer' anyway?
Well, do you mean we should not add non-existent viewer to
mailcap-mime-data in like this way?
(defvar mailcap-mime-data
`(("application"
[...]
,@(when (fboundp 'doc-view-mode)
'(("pdf"
(viewer . doc-view-mode)
(type . "application/pdf")
(test . (eq window-system 'x)))))
[...]
It would be perhaps better than adding the fboundp check to
the test token.