[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Branches are Scary
From: |
Yuri Khan |
Subject: |
Re: Branches are Scary |
Date: |
Fri, 18 Dec 2015 13:49:39 +0600 |
On Fri, Dec 18, 2015 at 1:28 PM, Eli Zaretskii <address@hidden> wrote:
>> > If you still plan substantial cleanup of your commits, just
>> > do not push them yet.
>>
>> Makes it hard to get comments on them, I think.
>
> How's that? Can you tell more details how getting comments requires
> squashing?
Getting comments doesn’t. Acting on comments sort of does.
Sure, you can push a follow-up commit with a “Post-review fix”
subject, but it makes history too detailed. Or you can squash fixes
into the commits that introduced the respective issues.
- Branches are Scary, Phillip Lord, 2015/12/17
- Re: Branches are Scary, Ingo Lohmar, 2015/12/17
- Re: Branches are Scary, Phillip Lord, 2015/12/17
- Re: Branches are Scary, John Wiegley, 2015/12/17
- Re: Branches are Scary, Eli Zaretskii, 2015/12/18
- Re: Branches are Scary,
Yuri Khan <=
- Re: Branches are Scary, Eli Zaretskii, 2015/12/18
- Re: Branches are Scary, Phillip Lord, 2015/12/18
- Re: Branches are Scary, Random832, 2015/12/18
- Re: Branches are Scary, Eli Zaretskii, 2015/12/18
- Re: Branches are Scary, Phillip Lord, 2015/12/18
Re: Branches are Scary, Eli Zaretskii, 2015/12/18