[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Merging the xwidget branch
From: |
joakim |
Subject: |
Re: Merging the xwidget branch |
Date: |
Tue, 19 Jan 2016 21:08:04 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) |
Eli Zaretskii <address@hidden> writes:
>> From: address@hidden
>> Cc: address@hidden
>> Date: Mon, 18 Jan 2016 22:52:00 +0100
>>
>> How about this?
>
> Looks good, except...
>
>> * emacsgtkfixed.c (emacs_fixed_gtk_widget_size_allocate)
>> (emacs_fixed_class_init):
> ^^^^^^^^^^^^^^^^^
> ...this. Something is missing after that colon, right?
>
>> New files for xwidgets:
>> * xwidget.c, xwidget.h, xwidget.el:
>
> This should just say
>
> * src/xwidget.c:
> * src/xwidget.h:
> * lisp/xwidget.el: New files.
>
>> Co-authored-by: Grégoire Jadi <address@hidden>
>
> This should be on a separate line by its own.
>
> Otherwise, it's good to go, thanks.
I pushed just now.
--
Joakim Verona
- Re: Merging the xwidget branch, (continued)
- Re: Merging the xwidget branch, joakim, 2016/01/09
- Re: Merging the xwidget branch, Wolfgang Jenkner, 2016/01/11
- Re: Merging the xwidget branch, joakim, 2016/01/11
- Re: Merging the xwidget branch, Eli Zaretskii, 2016/01/16
- Re: Merging the xwidget branch, joakim, 2016/01/17
- Re: Merging the xwidget branch, Eli Zaretskii, 2016/01/17
- Re: Merging the xwidget branch, joakim, 2016/01/18
- Re: Merging the xwidget branch, Eli Zaretskii, 2016/01/18
- Re: Merging the xwidget branch, joakim, 2016/01/18
- Re: Merging the xwidget branch, Eli Zaretskii, 2016/01/19
- Re: Merging the xwidget branch,
joakim <=
- Re: Merging the xwidget branch, Eli Zaretskii, 2016/01/19
- Re: Merging the xwidget branch, John Wiegley, 2016/01/20
- Re: Merging the xwidget branch, Nicolas Petton, 2016/01/20
- Re: Merging the xwidget branch, joakim, 2016/01/18