[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Emacs 25.0.04: Feature Request: Make called-interactively-p's argume
From: |
raman |
Subject: |
Re: Emacs 25.0.04: Feature Request: Make called-interactively-p's argument optional |
Date: |
Wed, 06 Jul 2016 08:14:03 -0700 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.0.95 (gnu/linux) |
Eli Zaretskii <address@hidden> writes:
>From memory the problem with called-interactively-p failing when called
from inside an around advice remain, Stefan fixed part of the bug, but I
also remember him saying that he was putting the rest of it on a stack
for some future fix.>> From: raman <address@hidden>
>> Date: Tue, 05 Jul 2016 18:46:31 -0700
>> Cc: address@hidden
>>
>> Here's one example of a large package (Emacspeak) and the number of
>> times the equivalent of interactive-p is used: It would be interesting
>> to validate the assertion "it's not used often" by examining other
>> large packages as well.
>>
>> Note: ems-interactive-p is what I wrote when interactive-p got
>> deprecated.
>>
>> grep ems-interactive-p *.el | wc
>> 1607 4781 79080
>> Lines Of Elisp In Emacspeak:
>> 18:44:33 raman-glaptop2 lisp $ wc *.el
>> ...
>> 79781 256614 2624155 total
>
> Did this change after Stefan fixed the bug you reported? Did you try
> to see afterwards whether the problems you recall are still there or
> solved?
>
--
- Re: Emacs 25.0.04: Feature Request: Make called-interactively-p's argument optional, (continued)
Re: Emacs 25.0.04: Feature Request: Make called-interactively-p's argument optional, Noam Postavsky, 2016/07/05