[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Proposal: font lock for `describe-variable`

From: Clément Pit--Claudel
Subject: Re: Proposal: font lock for `describe-variable`
Date: Wed, 28 Sep 2016 00:21:13 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0

I think Eli is pointing out that in every place where you made a modification 
to the code, you also changed the whitespace.  For example, you untabified all 
three lines of the following chunk.

-       (setq output
-             (format "This variable was introduced, or its default value was 
changed, in\nversion %s of Emacs.\n"
-                     custom-version))
+        (setq output
+              (format "This variable was introduced, or its default value was 
changed, in version %s of Emacs.\n"
+                      custom-version))


On 2016-09-27 23:45, Tianxiang Xiong wrote:
> @Eli I don't know what you mean, then. The diffs in the 0002 version are 
> definitely not due to whitespace changes; I explicitly removed the 
> whitespace-only changes from 0001.
> There /is/ a good amount of refactoring, simply because the previous code was 
> very hard to follow. The new code is ~40 lines shorter and, if I do say so 
> myself, much clearer.
> I've attached the 0002 version again in case there's something wrong with the 
> previous one.
> 2016-09-27 10:40 GMT-07:00 Eli Zaretskii <address@hidden 
> <mailto:address@hidden>>:
>     > From: Tianxiang Xiong <address@hidden <mailto:address@hidden>>
>     > Date: Tue, 27 Sep 2016 09:30:18 -0700
>     > Cc: address@hidden <mailto:address@hidden>, address@hidden 
> <mailto:address@hidden>,
>     >       Clément Pit--Claudel <address@hidden <mailto:address@hidden>>
>     >
>     > Even the 0002 version?
>     Yes.

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]