Re: The current state of the comment-cache branch

[Eli Zaretskii]

> Date: Sat, 24 Dec 2016 09:42:46 +0000
> From: Alan Mackenzie <address@hidden>
> Cc: address@hidden
> 
> > Can you show similar timings with that variable set to nil?  And in
> > particular in the use case reported by Paul back when bug#22884 was
> > filed?
> 
> master:                        101.939s            95.049s        103.546s
> (with open-paren-... nil)

Hmm... doesn't match my timings here.

With an optimized (-Og) build of Emacs 25.1.90, I get 42.844 with
open-paren-in-column-0-is-defun-start t and 62.234 nil.  With the
unoptimized build of the current master, I get 193.922 and 1117.469,
respectively.  The 193 sec result is marginally reasonable for an
unoptimized build, the 1117 sec result is IMO preposterous, and the
6-fold slowdown is IMO too much to be explained just by the variable.

Anyway, is your suggestion to adopt the code on that branch and set
open-paren-in-column-0-is-defun-start to nil?  If we are not going to
set it to nil, then the speed advantage is IMO too small to justify
the changes.

Also, I wonder why do we need all these changes in syntax.c, when the
problem is AFAIK only with C mode and its derivatives.  Are these
changes beneficial in any way to modes with non-C syntax?

Thanks.

P.S. What does "hwm" stand for in literal-cache-hwm?