emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [elpa] master 550ae83 1/2: [gnugo int] Decruft: Don't declare hook a


From: Stefan Monnier
Subject: Re: [elpa] master 550ae83 1/2: [gnugo int] Decruft: Don't declare hook and keymap vars.
Date: Wed, 08 Feb 2017 17:28:44 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux)

>     * packages/gnugo/gnugo.el (gnugo-board-mode-map):
>     Delete defvar; move init to top-level, prior to ‘provide’
>     form; conditionalize init on expected ‘?’ binding.

Hmm... I have been installing the exact reverse change in many packages
of the years.  IOW this changes "idiomatic code" to "non-idiomatic code".
Both options have advantages and disadvantages, so I'm curious why you
prefer the non-idiomatic way,


        Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]