[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [elpa] master 550ae83 1/2: [gnugo int] Decruft: Don't declare hook a

From: Thien-Thi Nguyen
Subject: Re: [elpa] master 550ae83 1/2: [gnugo int] Decruft: Don't declare hook and keymap vars.
Date: Fri, 10 Feb 2017 06:15:04 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux)

() Stefan Monnier <address@hidden>
() Thu, 09 Feb 2017 13:02:22 -0500

   >  (defvar MODE-map INIT)                   ; model C
   >  (define-derived-mode MODE ...)

   This is the idiomatic form.

OK, noted.

   The main benefit is that there's a clear place where the mode
   map is defined and `C-h o` will get you there.

Thanks for the tip.  ‘C-h o’ is new to me.  That's indeed a nice

   aesthetic problem is due
   to the use forward references.

   So, is it fair to say that the reason for the patch was to
   avoid those forward references?

Yes, exactly.

   >  (unless EXPECTED-MODE-map-BINDING

   Of course, this misfires if the user wants to change this
   EXPECTED-MODE-map-BINDING binding ;-)

True, that's the risk.

I'll release, wait a year or two for complaints, and revisit the
decision then -- perhaps ‘C-h o’ will in the meantime learn how
to accomodate some non-idiomatic forms, such as this one.

Thien-Thi Nguyen -----------------------------------------------
 (defun responsep (query)
   (pcase (context query)
     (`(technical ,ml) (correctp ml))
     ...))                              748E A0E8 1CB8 A748 9BFA
--------------------------------------- 6CE4 6703 2224 4C80 7502

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]