[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] unsafep: Add support for (funcall)

From: Stefan Monnier
Subject: Re: [PATCH] unsafep: Add support for (funcall)
Date: Tue, 28 Feb 2017 11:18:51 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux)

>> Hmm... I don't quite get it:
>> (funcall '<sym> ...)
>> is better written as
>> (<sym> ...)
>> so why/when do you see such code?  Could we rewrite it before unsafep
>> gets to look at it.

> Indeed, byte-compile-funcall rewrites such forms. I've just added this
> to remove a potential false positive from unsafep, as it's not only
> the byte compiler and optimizer that use it (for instance, ses.el uses
> it to warn the user about "unsafe" formulae).

But unsafep must call something like macroexpand-all or something like
that, so we could (should?) arrange for that to do the rewrite.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]