[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Refactor digest authentication in url-auth

From: Eli Zaretskii
Subject: Re: Refactor digest authentication in url-auth
Date: Sat, 11 Mar 2017 12:08:50 +0200

> From: Jarno Malmari <address@hidden>
> Cc: 
> Date: Sun, 05 Mar 2017 17:54:01 +0200
> For what it's worth I'd consider the refactoring patch (PATCH 1/2) quite
> safe to merge in and would suggest prioritizing reviewing efforts on the
> latter patch (PATCH 2/2) that contains the actual QOP feature.

Since no one seems to be interested to review this patch, I did that
myself.  I have two comments:

> +(defun url-digest-auth-build-response (key url realm attrs)
> +  "Compute authorization string for the given challenge using KEY.
> +
> +The strings looks like 'Digest username=\"John\", realm=\"The
> +Realm\", ...'

Typo: should be "look", not "looks".

> +(defun url-digest-find-new-key (url realm prompt)
> +  "Find new key either from auth-source or interactively.
> +The key is looked for based on URL and REALM.  If PROMPT is
> +non-nil, ask interactively in case credentials weren't found from
> +auth-source."

This function's doc string looks strikingly different from the rest of
the functions you wrote: not as detailed and clear as the rest.  Can
you rework it to be more in line with the rest of the functions?

With those minor issues fixed, I will push your changes.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]