[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Problem committing tests

From: Stephen Berman
Subject: Re: Problem committing tests
Date: Mon, 29 May 2017 10:08:43 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux)

On Mon, 29 May 2017 09:10:35 +0200 Thien-Thi Nguyen <address@hidden> wrote:

> () Stephen Berman <address@hidden>
> () Mon, 29 May 2017 00:40:48 +0200
>    I wanted to include some tests with the fix for bug#27121
>    that I just committed to master (d76c007); however, git
>    complained about trailing whitespace in two data files for
>    the tests.  This whitespace is part of the file format used
>    by todo-mode.el, so I cannot delete it.  I see that the
>    .gitattributes file in the repository lists several test
>    files for which whitespace warnings should be ignored; should
>    I add the todo-mode test data files to the list?  Or is there
>    another or better way to tell git to ignore this whitespace
>    and commit the files?
> I think it would be cool to restructure the process so that the
> eol ws-requiring data is generated at run-(test-)time from data
> that has no eol ws.  This is more work, but:

Unfortunately, it is more than I currently have time for with my
knowledge of and experience with git and the Emacs test environment.

> - It is explicit.
> - It avoids possible future lossage if the DVCS changes.
> - It avoids possible future lossage via PEBKAC or ignorance.
>   (Just think, what if that fool ttn fubars this somehow!?)
> - If the work should happen to be algorithmic (it is, what a
>   surprise! :-D), it could be generalized and re-used.
> - If it is written well, it could be documented and exported.
> So, i urge you to put in the effort here, slap your name on it,
> and bask in the glory of future Q/A chains terminating w/ a
> time-saving link to righteous code (and relax{ed,ing} docs).
> IOW, it is good to cope, better to create, best to invest.

I agree, but I'm afraid being good is the best I can hope for for now.
So I'll wait a bit to see if any other manageable suggestions come up,
otherwise I'll do the .gitattributes workaround.

Steve Berman

reply via email to

[Prev in Thread] Current Thread [Next in Thread]