[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [ELPA] New package: find-dups

From: Michael Heerdegen
Subject: Re: [ELPA] New package: find-dups
Date: Wed, 11 Oct 2017 21:25:36 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux)

Hi Eli,

Thanks for your comment.

> Apologies for barging into the middle of a discussion, but starting
> processes and making strings out of their output to process just a
> portion of a file is sub-optimal, because process creation is not
> cheap.  It is easier to simply read a predefined number of bytes into
> a buffer; insert-file-contents-literally supports that.  Likewise with
> md5sum: we have the md5 primitive for that.

That's one of the details I delayed until I know whether we want this
for inclusion.  My first version used `insert-file-contents-literally'
but I ran into problems, and calling `debug' crashed Emacs, so I gave up
for the moment.  Personally, I don't care that much because it doesn't
make a big speed difference, but yes, I know it's not absolutely
correct, and I would care about this.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]