[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: fix for bug#29935 copyright-update inserts year at random places
From: |
Stephen Leake |
Subject: |
Re: fix for bug#29935 copyright-update inserts year at random places |
Date: |
Thu, 11 Jan 2018 10:48:14 -0600 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (windows-nt) |
Eli Zaretskii <address@hidden> writes:
>> From: Stephen Leake <address@hidden>
>> Date: Mon, 08 Jan 2018 10:56:59 -0600
>>
>> This thread is nominally about patching emacs-26 to fix a bug. The patch
>> I've posted is a minimal fix; adding code or redesigning to handle frames
>> better is feature-creep, so it should be done on master.
>
> I think the bug happens because we use save-window-excursion, and
> switch buffers inside it. The cure should be not to do what hurts.
> Can this be done in this case? If not, why not? And why do we use
> save-window-excursion in the first place? that's not the usual way to
> display a buffer whose contents is referenced in an error message or a
> prompt.
I posted an update on debbugs, giving a recipe for reproducing the bug,
and giving the results of various suggested fixes.
I tried deleting save-window-excursion; that does not fix the bug.
I don't have a rationale for the current design of the function, but I
think redesigning it should be done on master, not emacs-26.
--
-- Stephe
- Re: fix for bug#29935 copyright-update inserts year at random places, (continued)
- Re: fix for bug#29935 copyright-update inserts year at random places, Stefan Monnier, 2018/01/04
- Re: fix for bug#29935 copyright-update inserts year at random places, Stephen Leake, 2018/01/04
- Re: fix for bug#29935 copyright-update inserts year at random places, Stefan Monnier, 2018/01/04
- Re: fix for bug#29935 copyright-update inserts year at random places, martin rudalics, 2018/01/07
- Re: fix for bug#29935 copyright-update inserts year at random places, Stefan Monnier, 2018/01/07
- Re: fix for bug#29935 copyright-update inserts year at random places, martin rudalics, 2018/01/08
- Re: fix for bug#29935 copyright-update inserts year at random places, Stefan Monnier, 2018/01/08
- Re: fix for bug#29935 copyright-update inserts year at random places, Stephen Leake, 2018/01/08
- Re: fix for bug#29935 copyright-update inserts year at random places, martin rudalics, 2018/01/08
- Re: fix for bug#29935 copyright-update inserts year at random places, Eli Zaretskii, 2018/01/08
- Re: fix for bug#29935 copyright-update inserts year at random places,
Stephen Leake <=
- Re: fix for bug#29935 copyright-update inserts year at random places, martin rudalics, 2018/01/08
- Re: fix for bug#29935 copyright-update inserts year at random places, Stefan Monnier, 2018/01/08
- Re: fix for bug#29935 copyright-update inserts year at random places, martin rudalics, 2018/01/09
- Re: fix for bug#29935 copyright-update inserts year at random places, Stefan Monnier, 2018/01/09
- Re: fix for bug#29935 copyright-update inserts year at random places, martin rudalics, 2018/01/10