Re: [PATCH] New option to make C-x 4 a use file-less ChangeLog buffers

[Basil L. Contovounesios]

Hi João, just a minor question:

João Távora <address@hidden> writes:

> From 867540c9310ee12ca477e744571d93f56f5f888d Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Jo=C3=A3o=20T=C3=A1vora?= <address@hidden>
> Date: Sat, 14 Jul 2018 18:29:48 +0100
> Subject: [PATCH] New option to make C-x 4 a use file-less ChangeLog buffers
>
> * lisp/vc/add-log.el (add-log-file-name): Update docstring.
> (add-log-use-pseudo-changelog): New defcustom.
> (add-log-find-changelog-buffer): New helper.
> (add-change-log-entry): Can work with ChangeLog file-less
> buffers.  Change name of argument FILE-NAME arg to be more
> explicit.  Explain new meaning of arg in docstring.
> (add-log--changelog-buffer-p): New helper.
>
> * lisp/vc/log-edit.el (log-edit-changelog-entries): Use
> add-log-use-pseudo-changelog and add-log-find-changelog-buffer.
> ---
>  lisp/vc/add-log.el  | 67 +++++++++++++++++++++++++++++++++++++--------
>  lisp/vc/log-edit.el |  6 ++--
>  2 files changed, 59 insertions(+), 14 deletions(-)
>
> diff --git a/lisp/vc/add-log.el b/lisp/vc/add-log.el
> index 4d69aac454..983024327c 100644
> --- a/lisp/vc/add-log.el
> +++ b/lisp/vc/add-log.el
> @@ -744,6 +744,7 @@ find-change-log
>    file-name)
>  
>  (defun add-log-file-name (buffer-file log-file)
> +  "Compute file-name of BUFFER-FILE as displayed in LOG-FILE."
>    ;; Never want to add a change log entry for the ChangeLog file itself.
>    (unless (or (null buffer-file) (string= buffer-file log-file))
>      (if add-log-file-name-function
> @@ -767,15 +768,49 @@ add-log-file-name
>         (file-name-sans-versions buffer-file)
>       buffer-file))))
>  
> +(defcustom add-log-use-pseudo-changelog nil
> +  "If non-nil, don't create ChangeLog files for log entries."
> +  :type :boolean)
> +
> +(put 'add-log-use-pseudo-changelog 'safe-local-variable 'booleanp)

Any reason to prefer this over adding ":safe 'booleanp" directly to the
defcustom?

Thanks,

-- 
Basil