emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: harfbuzz 2f72162: Fix crash in the Cairo build


From: Eli Zaretskii
Subject: Re: harfbuzz 2f72162: Fix crash in the Cairo build
Date: Fri, 14 Dec 2018 15:29:12 +0200

> From: Robert Pluim <address@hidden>
> Date: Fri, 14 Dec 2018 13:18:41 +0100
> Cc: Ari Roponen <address@hidden>
> 
> Eli, what would be your preferred type of solution to avoid this in
> future?

If at all possible, I prefer a single definition of each struct, with
as few #ifdef's as possible.  If some member is not used in some
configuration, I prefer to have it anyway, unless it cannot be
compiled in the configuration(s) that don't use it (e.g., because it
uses a data type that is only visible in some configurations).

> At the very least I propose syncing the comments:

Yes, please push.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]