emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: harfbuzz 2f72162: Fix crash in the Cairo build


From: Robert Pluim
Subject: Re: harfbuzz 2f72162: Fix crash in the Cairo build
Date: Wed, 19 Dec 2018 09:32:52 +0100

Robert Pluim <address@hidden> writes:

> Paul Eggert <address@hidden> writes:
>
>> Thanks, looks good to me too. One minor point:
>>
>> On 12/17/18 4:41 AM, Robert Pluim wrote:
>>> +#ifdef HAVE_XFT
>>> +#include <X11/Xlib.h>
>>> +#include <X11/Xft/Xft.h>
>>> +#endif
>>> +#ifdef USE_CAIRO
>>> +#include <cairo-ft.h>
>>> +#endif
>>
>> Please indent the include directives by using "# include" (with a
>> space after "#").
>
> Fixed.

BTW, Emacs has ~500 instances of this rule not being followed. Iʼm
assuming that a mass change (similarly to mass whitespace fixes) would
be frowned upon.

Robert



reply via email to

[Prev in Thread] Current Thread [Next in Thread]