Re: [Emacs-diffs] master 1072155: Avoid duplicate entries in process-environment after re-dumping

[Eli Zaretskii]

> Date: Tue, 2 Apr 2019 13:11:53 -0700
> From: "Daniel Colascione" <address@hidden>
> Cc: "Daniel Colascione" <address@hidden>,
>  address@hidden
> 
> >> Don't we want to reset process-environment to its old value in
> >> dump_unwind_cleanup?
> >
> > You are thinking about re-dumping from an interactive session?
> 
> Yes
> 
> > In
> > that case, probably yes.  But currently we only support dumping from
> > batch sessions, and in that case I don't see a need to restore
> > process-environment, am I missing something?
> 
> We "support" dumping only from dedicated batch instances in that for now
> we should consider only bugs in that use case release-blocking, but I
> don't want to gratuitously break other use cases like dumping interactive
> sessions without killing them, since these use cases are meant to work and
> we'll give them the same level of support someday soon.

OK, but is there any reason dump_unwind_cleanup doesn't restore
post-gc-hook?  Omission?