Re: [Emacs-diffs] master 36dc39b: * lisp/gnus/gnus-sum.el: Prepare for lexical-binding

[Basil L. Contovounesios]

address@hidden (Stefan Monnier) writes:

> branch: master
> commit 36dc39bfbf1a307769bd62dbe1311a1935737b51
> Author: Stefan Monnier <address@hidden>
> Commit: Stefan Monnier <address@hidden>
>
>     * lisp/gnus/gnus-sum.el: Prepare for lexical-binding

[...]

>     (gnus-summary-move-article): Use dolist.

[...]

> @@ -9979,7 +10038,7 @@ ACTION can be either `move' (the default), `crosspost' 
> or `copy'."
>                (crosspost "Crosspost" "Crossposting")))
>       (copy-buf (save-excursion
>                   (nnheader-set-temp-buffer " *copy article*")))
> -     art-group to-method new-xref article to-groups
> +        art-group to-method new-xref to-groups
>       articles-to-update-marks encoded)
>      (unless (assq action names)
>        (error "Unknown action %s" action))
> @@ -10029,8 +10088,7 @@ ACTION can be either `move' (the default), 
> `crosspost' or `copy'."
>                 (or (car select-method)
>                     (gnus-group-decoded-name to-newsgroup))
>                 articles)
> -    (while articles
> -      (setq article (pop articles))
> +    (dolist (article articles)
>        ;; Set any marks that may have changed in the summary buffer.
>        (when gnus-preserve-marks
>       (gnus-summary-push-marks-to-backend article))

The dolist and while implementations aren't equivalent here (see my own
attempt at this[1] and the resulting bug[2]), so I took the liberty of
re-applying Yamaoka-san's fix[3] on top of your changes in the meantime.

[1: 03e916beb0]: Fix Gnus duplicate article unsuppression
  2019-03-24 10:11:29 -0700
  
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=03e916beb0186f3707cd238650298870bf471575

[2]: https://debbugs.gnu.org/33653#134

[3: 3e5e097fdf]: Make `move article' work again (bug#33653)
  2019-04-08 23:55:09 +0100
  
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3e5e097fdf056f4b3440993dd25ebdbad436abc3

Thanks,

-- 
Basil