[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] master 36dc39b: * lisp/gnus/gnus-sum.el: Prepare for l
|
From: |
Basil L. Contovounesios |
|
Subject: |
Re: [Emacs-diffs] master 36dc39b: * lisp/gnus/gnus-sum.el: Prepare for lexical-binding |
|
Date: |
Tue, 09 Apr 2019 16:38:12 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Andy Moreton <address@hidden> writes:
> On Mon 08 Apr 2019, Stefan Monnier wrote:
>
>>> The dolist and while implementations aren't equivalent here (see my own
>>> attempt at this[1] and the resulting bug[2]), so I took the liberty of
>>> re-applying Yamaoka-san's fix[3] on top of your changes in the meantime.
>>
>> Duh, indeed, thanks,
>>
>>
>> Stefan
>
> As this problem has now bitten twice, perhaps it merits a comment in the
> code to prevent it being "fixed" again...
Good point; done[1].
[1: e1a457e635]: ; Warn of while/dolist pitfall in gnus-sum.el
2019-04-09 16:32:27 +0100
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=e1a457e63530cd566a1bc2957b70221bb6f76984
Thanks,
--
Basil