emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Unbreak build when building without GMP support.


From: Eli Zaretskii
Subject: Re: [PATCH] Unbreak build when building without GMP support.
Date: Wed, 24 Apr 2019 22:06:13 +0300

> From: Philipp Stephani <address@hidden>
> Date: Wed, 24 Apr 2019 20:49:34 +0200
> Cc: Emacs developers <address@hidden>, Philipp Stephani <address@hidden>
> 
> > Btw, why are we including emacs-module.h in lisp.h?  IME, this usually
> > causes trouble, so it is best to avoid that.
> 
> lisp.h needs types from emacs-module.h to define Lisp_Module_Function.

A single data type?  I'd rather move XMODULE_FUNCTION to
emacs-module.c, and the data type definition and all the other related
stuff to emacs-module.h.  It isn't worth the hassle.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]