Re: [PATCH] Unbreak build when building without GMP support.

[Philipp Stephani]

Am Mi., 24. Apr. 2019 um 21:31 Uhr schrieb Eli Zaretskii <address@hidden>:
>
> > From: Philipp Stephani <address@hidden>
> > Date: Wed, 24 Apr 2019 21:19:54 +0200
> > Cc: Emacs developers <address@hidden>, Philipp Stephani <address@hidden>
> >
> > Am Mi., 24. Apr. 2019 um 21:06 Uhr schrieb Eli Zaretskii <address@hidden>:
> > >
> > > > From: Philipp Stephani <address@hidden>
> > > > Date: Wed, 24 Apr 2019 20:49:34 +0200
> > > > Cc: Emacs developers <address@hidden>, Philipp Stephani <address@hidden>
> > > >
> > > > > Btw, why are we including emacs-module.h in lisp.h?  IME, this usually
> > > > > causes trouble, so it is best to avoid that.
> > > >
> > > > lisp.h needs types from emacs-module.h to define Lisp_Module_Function.
> > >
> > > A single data type?  I'd rather move XMODULE_FUNCTION to
> > > emacs-module.c, and the data type definition and all the other related
> > > stuff to emacs-module.h.  It isn't worth the hassle.
> >
> > We shouldn't move anything to emacs-module.h because it's a public
> > header, to be used outside of Emacs.
>
> Then keep them in lisp.h, but make them self-sufficient.  Which types
> does Lisp_Module_Function need that are defined by emacs-module.h?

Turns out that it's relatively straightforward to move the structure
type itself out of lisp.h, so I've just did that.