emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Improve Gravatar support


From: Lars Ingebrigtsen
Subject: Re: [PATCH] Improve Gravatar support
Date: Mon, 22 Jul 2019 15:31:17 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

After skimming (on holiday), looks good to me.  Extremely minor comments
below:

"Basil L. Contovounesios" <address@hidden> writes:

>  (defcustom gnus-gravatar-too-ugly gnus-article-x-face-too-ugly
> -  "Regexp matching posters whose avatar shouldn't be shown automatically."
> -  :type '(choice regexp (const nil))
> +  "Regexp matching posters whose avatar shouldn't be shown automatically.
> +Nil means show all avatars."

We don't capitalise nil in documentation, do we?

> -       ;; The buffer can be gone at this time
> -       (when (buffer-live-p (current-buffer))
> +      ;; The buffer can be gone at this time.
> +      (when (buffer-name)

I think buffer-live-p is clearer than just saying buffer-name.

> -  (interactive (list t)) ;; When type `W D g'
> +  (interactive "p") ;; When type `W D g'

Perhaps grammer fix?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



reply via email to

[Prev in Thread] Current Thread [Next in Thread]