|
From: | Basil L. Contovounesios |
Subject: | Re: [PATCH] Improve Gravatar support |
Date: | Mon, 22 Jul 2019 22:42:27 +0100 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Andy Moreton <address@hidden> writes: > On Mon 22 Jul 2019, Basil L. Contovounesios wrote: > >> The attached patch adds support for more Gravatar features, improves >> existing docs, and reduces some code duplication. WDYT? > > This patch seems to mix three things: > - conversion to lexical binding > - minor bugfixes > - new features > > It is better to put each in a separate patch, to ease later bisection if > needed. More often I see reviewers express the opposite feeling here, but since I don't personally mind and you asked so nicely:
0001-Clarify-Gravatar-docs.patch
Description: Text Data
0002-Use-lexical-binding-for-Gravatar-support.patch
Description: Text Data
0003-DRY-in-gravatar.el.patch
Description: Text Data
0004-Fix-some-minor-gravatar.el-issues.patch
Description: Text Data
0005-Make-gravatar.el-more-configurable.patch
Description: Text Data
Since the first patch only touches existing documentation, it could even be applied to emacs-26. Eli? The other patches also address Lars' initial feedback: https://lists.gnu.org/archive/html/emacs-devel/2019-07/msg00529.html WDYT? Thanks, -- Basil
[Prev in Thread] | Current Thread | [Next in Thread] |