[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] master 6cd5678: Clarify compiler-pacifier in frame.c

From: Paul Eggert
Subject: Re: [Emacs-diffs] master 6cd5678: Clarify compiler-pacifier in frame.c
Date: Sat, 24 Aug 2019 17:52:05 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0

Eli Zaretskii wrote:
when geometry is non-zero, x and y are

And that means the initializations "x = 0, y = 0" were indeed unnecessary. The code works just fine without those initializations, because the values of x and y are not examined unless XParseGeometry has successfully set them.

Newer GCC is smart enough to figure this out, at least with the default optimizations. Other platforms evidently aren't smart enough.

If we
want this to be abundantly clear, we should have a comment there to
the above effect.

Sure, I installed the attached.

Attachment: 0001-Clarify-Fx_parse_geometry-initialization.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]