[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] master 6cd5678: Clarify compiler-pacifier in frame.c

From: Eli Zaretskii
Subject: Re: [Emacs-diffs] master 6cd5678: Clarify compiler-pacifier in frame.c
Date: Mon, 26 Aug 2019 10:54:04 +0300

> Cc: address@hidden
> From: Paul Eggert <address@hidden>
> Date: Sun, 25 Aug 2019 23:34:25 -0700
> > UNINIT ... only works in a Git repository.
> > So it's a semi-kludgey semi-solution, not really better
> > than an explicit initialization with a comment.
> UNINIT works outside of Git repositories, since it depends on GCC_LINT which 
> can 
> be set independently of whether one is in a Git repository.

That's not "working" in my book.  The warnings will re-appear if one
compiles outside of Git with suitable GCC options, so the solution is
incomplete at best.

> Admittedly UNINIT is a bit of a kludge, but it's the best kludge we have in 
> the 
> area.

An explicit initialization is a tad better, as it doesn't require any
tinkering with obscure settings.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]