emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [BUG] Tab commands selecting by name


From: Ingo Lohmar
Subject: Re: [BUG] Tab commands selecting by name
Date: Sun, 13 Oct 2019 22:38:43 +0200

On Sun, Oct 13 2019 23:12 (+0300), Juri Linkov wrote:

>> I forgot to mention a crucial ingredient, because it's so natural for
>> me: I have NOT turned on tab-bar-mode --- I do not want to see tabs,
>> just to use persistent window configs.  In that case, I think, the
>> keymap you are talking about is not in play.  So I am just using the
>> commands themselves, via actual keys.
>>
>> But I don't really understand why the current-tab update is best placed
>> in that helper function, anyway, presumably to save some updating?
>
> I tried to avoid using window-configuration-change-hook
> and indeed the current implementation uses no hooks at all.
>
> But it seems now we still need to use window-configuration-change-hook
> to update the current tab name on every window configuration change.
> Or at least to use this hook when tab-bar-mode is disabled.
>
> Or there is an alternative - to update the current tab name
> explicitly in every command that uses tab names, and even in
> their interactive spec that reads a tab name.

That's what I did (see my original message), and I think it is
sufficient --- there is no need to involve any hooks: Just declare that
`tab-bar-tabs' is the "single source of truth" for all but the
lowest-level functions, and update the current tab name (and, possibly,
window configuration?) at its start.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]