emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 2bb0703 1/2: lisp/*.el: Force non-nil result to t, to match d


From: Juanma Barranquero
Subject: Re: master 2bb0703 1/2: lisp/*.el: Force non-nil result to t, to match docstring
Date: Thu, 17 Oct 2019 05:45:09 +0200


On Thu, Oct 17, 2019 at 4:50 AM Ergus <address@hidden> wrote:

> AFAIK: In lisp true means anything non-nil for most of the
> purposes.

Yes. And still, most predicates are defined as returning t/nil.

> This change I am not sure how convenient is it. It just ads
> some extra complexity to read with no benefit.

There are lots of places in the sources that already use (and ... t) to normalize the result to t. It's not a lot of complexity.

> Maybe it made more sense to fix the docstrings to say non-nil instead of
> forcing the code to return t?

That means that you're sure that there's no code out there depending on the (documented) result being t.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]