emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Allow hiding stashes from vc-dir


From: Stefan Monnier
Subject: Re: [PATCH] Allow hiding stashes from vc-dir
Date: Fri, 18 Oct 2019 09:22:22 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

> +(declare-function cl-subseq "cl-extra" (seq start &optional end))

Wrong fix: if you want to use cl-lib functions, then you need to
(require 'cl-lib) outside of an eval-when-compile.  IOW you need:

    diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el
    index 9715aea1fd..aa3b41454d 100644
    --- a/lisp/vc/vc-git.el
    +++ b/lisp/vc/vc-git.el
    @@ -102,8 +102,8 @@
     
     ;;; Code:
     
    +(require 'cl-lib)
     (eval-when-compile
    -  (require 'cl-lib)
       (require 'subr-x) ; for string-trim-right
       (require 'vc)
       (require 'vc-dir))


-- Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]