[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Allow hiding stashes from vc-dir

From: Robert Pluim
Subject: Re: [PATCH] Allow hiding stashes from vc-dir
Date: Fri, 18 Oct 2019 16:07:33 +0200

>>>>> On Fri, 18 Oct 2019 09:22:22 -0400, Stefan Monnier <address@hidden> said:

    >> +(declare-function cl-subseq "cl-extra" (seq start &optional end))
    Stefan> Wrong fix: if you want to use cl-lib functions, then you need to
    Stefan> (require 'cl-lib) outside of an eval-when-compile.  IOW you need:

    Stefan>     diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el
    Stefan>     index 9715aea1fd..aa3b41454d 100644
    Stefan>     --- a/lisp/vc/vc-git.el
    Stefan>     +++ b/lisp/vc/vc-git.el
    Stefan>     @@ -102,8 +102,8 @@
    Stefan>      ;;; Code:
    Stefan>     +(require 'cl-lib)
    Stefan>      (eval-when-compile
    Stefan>     -  (require 'cl-lib)
    Stefan>        (require 'subr-x) ; for string-trim-right
    Stefan>        (require 'vc)
    Stefan>        (require 'vc-dir))

I believe you [1]. Although in my mind the whole point of the autoload
cookies is that you donʼt need to require the whole of cl-lib just to
use one of its functions.

I guess with that itʼs ready to push from my end. Lars, does it work
the way you want?

[1]  I did test that it works, though :-)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]