emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 270ca8c: Fix internal-lisp-face-attributes to match face.


From: Eli Zaretskii
Subject: Re: master 270ca8c: Fix internal-lisp-face-attributes to match face.
Date: Sun, 20 Oct 2019 19:08:48 +0300

> From: Stephen Berman <address@hidden>
> Date: Sun, 20 Oct 2019 17:44:06 +0200
> Cc: Jimmy Aguilar Mena <address@hidden>
> 
> >     * lisp/face-remap.el (internal-lisp-face-attributes): Updated the
>                                                             ^^^^^^^
> 
> The conventional practice is to use the imperative form of verbs in
> commit messages (so here "Update").  (I couldn't find documentation of
> this practice

Because there's nothing wrong with "Updated", IMO.  You will find, for
example, "Function removed" and the likes in the logs.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]