Re: master a6b5985: Avoid duplicated character classes in rx

[Mattias Engdegård]

Stefan Monnier <address@hidden>:

> Probably, but I still think it's bad practice to use the return value of
> an operation which is fundamentally a side-effect.

Very well, it has now been wrapped in (progn ... t).

Juanma Barranquero <address@hidden>:

> So you've never written
> 
> (if (setq var value) ...)

Not so much, but I find it harder to avoid

  (while (setq v e) ...)

lacking tail-recursive loops.

> Thinking about converting it to cl-pushnew is what made me look closer at 
> this code in
> the first place ;-)

I prefer not using cl in rx.el at all for messy bootstrap reasons. (cl-pushnew 
is a macro, but I'd rather not tempt fate.)