Re: master 5ee43ba0df causing display hangs?

[Yuri D'Elia]

On Tue, Dec 10 2019, Eli Zaretskii wrote:
> Thanks.
>
> Please show the face that is refetenced in frame #5 as face_name, and
> all its attributes. AFAIU, this is the original face being merged
> here.
>
> The 'quote' thing probably means some attribute is redundantly quoted,
> but maybe I'm missing something.

That's indeed the problem.

#1  0x00005555556e1b2e in merge_named_face (w=0x5555577d4990, f=0x55555617e280,
    face_name=XIL(0x1154e20), to=0x7fffffff67f0, 
named_merge_points=0x7fffffff62d0,
    attr_filter=LFACE_EXTEND_INDEX) at xfaces.c:2223
(gdb) pp face_name
gnus-header-content

gnus-header-content inherits indeed a redundant quote:

((:family . unspecified) (:foundry . unspecified) (:width . unspecified)
 (:height . unspecified) (:weight . unspecified) (:slant . unspecified)
 (:underline . unspecified) (:overline . unspecified) (:extend . unspecified)
 (:strike-through . unspecified) (:box . unspecified) (:inverse-video . 
unspecified)
 (:foreground . unspecified) (:background . unspecified) (:stipple . 
unspecified)
 (:inherit quote mu4e-header-value-face))

I've found where I had this incorrectly set. After removing the quote
the loop properly terminates.

So it looks like a good fix would be first to ensure a failure in the
inner for loop in get_lface_attributes properly terminates. And also to
check for an explicit face symbol in inherit?