emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 5ee43ba0df causing display hangs?


From: Eli Zaretskii
Subject: Re: master 5ee43ba0df causing display hangs?
Date: Wed, 11 Dec 2019 19:14:06 +0200

> From: Yuri D'Elia <address@hidden>
> Cc: address@hidden
> Date: Wed, 11 Dec 2019 12:36:52 +0100
> 
> gnus-header-content inherits indeed a redundant quote:
> 
> ((:family . unspecified) (:foundry . unspecified) (:width . unspecified)
>  (:height . unspecified) (:weight . unspecified) (:slant . unspecified)
>  (:underline . unspecified) (:overline . unspecified) (:extend . unspecified)
>  (:strike-through . unspecified) (:box . unspecified) (:inverse-video . 
> unspecified)
>  (:foreground . unspecified) (:background . unspecified) (:stipple . 
> unspecified)
>  (:inherit quote mu4e-header-value-face))
> 
> I've found where I had this incorrectly set. After removing the quote
> the loop properly terminates.
> 
> So it looks like a good fix would be first to ensure a failure in the
> inner for loop in get_lface_attributes properly terminates. And also to
> check for an explicit face symbol in inherit?

OK, so it's indeed a cockpit error.  I installed the change you
proposed to terminate the outer loop in face_inherited_attr in such
cases.

As for the other part, I'm not sure what you are proposing -- what do
you mean by "check for an explicit face symbol in inherit"?

Thanks.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]