[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master f51f963: Fix some side-effecting uses of make-text-button
From: |
Paul Eggert |
Subject: |
Re: master f51f963: Fix some side-effecting uses of make-text-button |
Date: |
Thu, 4 Jun 2020 17:58:01 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 |
On 6/4/20 3:44 PM, Stefan Monnier wrote:
> So, IIUC we consider `make-text-button` to be functional rather than
> side-effecting, right?
It *ought* to be functional but it's currently not, because make-text-button has
a side effect on its argument string.
How about the attached patch? This would mean SLY would need the patch I sent in
earlier[1] since the attached patch is not 100% compatible with existing Emacs;
however, it does make make-text-button more functional and that's a good thing.
[1] https://lists.gnu.org/r/emacs-devel/2020-06/msg00152.html
make-text-button.diff
Description: Text Data
- Re: master f51f963: Fix some side-effecting uses of make-text-button, Stefan Monnier, 2020/06/04
- Re: master f51f963: Fix some side-effecting uses of make-text-button,
Paul Eggert <=
- Re: master f51f963: Fix some side-effecting uses of make-text-button, Basil L. Contovounesios, 2020/06/05
- Re: master f51f963: Fix some side-effecting uses of make-text-button, Paul Eggert, 2020/06/05
- Re: master f51f963: Fix some side-effecting uses of make-text-button, Pip Cet, 2020/06/06
- Re: master f51f963: Fix some side-effecting uses of make-text-button, Paul Eggert, 2020/06/06
- Re: master f51f963: Fix some side-effecting uses of make-text-button, Pip Cet, 2020/06/06