Re: master f51f963: Fix some side-effecting uses of make-text-button

[Stefan Monnier]

>        (make-text-button name nil
>                          'type 'apropos-library
>                          'face 'apropos-symbol
> -                        'apropos-symbol name)
> -      name)))
> +                        'apropos-symbol name))))

So, IIUC we consider `make-text-button` to be functional rather than
side-effecting, right?

> @@ -202,7 +202,7 @@ The format has been repaired and the variable modified 
> accordingly.
>  You can save the current value through the customize system by
>  either clicking or hitting return "
>            (make-text-button
> -           "here" nil
> +           (copy-sequence "here") nil
>             'face '(:weight bold :inherit button)
>             'mouse-face '(:weight normal :background "gray50" :inherit button)
>             'follow-link t

So, here why do we need to `copy-sequence`?


        Stefan