emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 3de31e7: Fix compilation of image.c on MS-Windows


From: Lars Ingebrigtsen
Subject: Re: master 3de31e7: Fix compilation of image.c on MS-Windows
Date: Mon, 09 Nov 2020 17:04:29 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

eliz@gnu.org (Eli Zaretskii) writes:

>     Fix compilation of image.c on MS-Windows
>
>     This is a followup to last change in image.c.
>     * src/image.c (rsvg_handle_get_intrinsic_dimensions): Define to
>     call fn_rsvg_handle_get_intrinsic_dimensions.
>     (svg_css_length_to_pixels): Compile only for librsvg >= 2.46.0, as
>     RsvgLength type was not defined before.

This leads to the following warnings on Debian bullseye, apparently:

image.c: In function ‘svg_css_length_to_pixels’:
image.c:9769:13: warning: this statement may fall through 
[-Wimplicit-fallthrough=]
 9769 |       value = dpi * value / 2.54;
      |       ~~~~~~^~~~~~~~~~~~~~~~~~~~
image.c:9770:5: note: here
 9770 |     case RSVG_UNIT_MM:
      |     ^~~~
image.c:9776:13: warning: this statement may fall through 
[-Wimplicit-fallthrough=]
 9776 |       value = dpi * value / 72;
      |       ~~~~~~^~~~~~~~~~~~~~~~~~
image.c:9777:5: note: here
 9777 |     case RSVG_UNIT_PC:
      |     ^~~~
image.c:9779:13: warning: this statement may fall through 
[-Wimplicit-fallthrough=]
 9779 |       value = dpi * value / 6;
      |       ~~~~~~^~~~~~~~~~~~~~~~~
image.c:9780:5: note: here
 9780 |     case RSVG_UNIT_IN:
      |     ^~~~


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



reply via email to

[Prev in Thread] Current Thread [Next in Thread]